Skip to content

Surface::skylightToProjectedFloorRatio was incorrectly forwarding to skylightToRoofRatio #5581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anchapin merged 2 commits into from
Jan 9, 2026
+2 −1
Merged

Surface::skylightToProjectedFloorRatio was incorrectly forwarding to skylightToRoofRatio #5581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49b5243
Redo git blame ignore rev for #5576 after squash merging
jmarrec Jan 8, 2026
3e0961d
Surface::skylightToProjectedFloorRatio was incorrectly forwarding to …
jmarrec Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .git-blame-ignore-revs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,3 +160,4 @@ ae602de89105983bf762cf1e6afd33d63d81b4a6

# [chore] Org and copyright year updates for OS 311 [David Goldwasser, 2026-01-05]
7a409fb41f6b0602ef2a6a018c9b3d33934571af
3c5a13b05d17ad83bca6ee84ca130b5c1c7f1dda
Copy link
Collaborator Author

@jmarrec jmarrec Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redo ignoring org rename

#5576 (comment)

2 changes: 1 addition & 1 deletion src/model/Surface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2340,7 +2340,7 @@ namespace model {
}

double Surface::skylightToProjectedFloorRatio() const {
return getImpl<detail::Surface_Impl>()->skylightToRoofRatio();
return getImpl<detail::Surface_Impl>()->skylightToProjectedFloorRatio();
Copy link
Collaborator Author

@jmarrec jmarrec Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad forward

}

boost::optional<SubSurface> Surface::setWindowToWallRatio(double wwr) {
Expand Down