Skip to content

Conversation

@yamilbknsu
Copy link
Collaborator

Despite what the message in the commit might suggest, I implement a Sequential version of the island detection algorithm that increases memory requirements but reduced work duplication.

This time the algorithm ran instantly for the small study area and produced almost the same output. This version returns 2 more edges than the parallel one. My explanation for this is that those two edges didn't have enough outward connectivity (since I'm only using forward adjacency) but were still reachable from a larger component.

@yamilbknsu yamilbknsu requested a review from Copilot February 11, 2026 16:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a selectable sequential implementation for the island detection algorithm, allowing callers/configuration to choose between the existing parallel scan and a component-wise sequential scan (trading memory for less duplicated work).

Changes:

  • Added parallel_execution flag to island detection configuration and threaded it through graph construction.
  • Updated island_detection_algorithm to support parallel vs sequential execution paths.
  • Updated example configuration to include parallel_execution.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File Description
rust/bambam-omf/src/graph/omf_graph.rs Passes parallel_execution through to the island detection algorithm.
rust/bambam-omf/src/graph/component_algorithm.rs Implements sequential component scan path and gates parallel behavior behind a flag.
rust/bambam-omf/src/app/network.rs Extends island detection configuration with parallel_execution.
configuration/bambam-omf/travel-mode-filter.json Adds parallel_execution to the sample config.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI commented Feb 11, 2026

@yamilbknsu I've opened a new pull request, #102, to work on those changes. Once the pull request is ready, I'll request review from you.

yamilbknsu and others added 3 commits February 11, 2026 11:57
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: yamilbknsu <1139432+yamilbknsu@users.noreply.github.com>
Optimize midpoint computation in island detection BFS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants