Skip to content

Web Crawl updates #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ppinchuk merged 3 commits into from
Jul 15, 2025
Merged

Web Crawl updates #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
997470d
Add page limit to crawl
ppinchuk Jul 15, 2025
6c2a988
Bump version
ppinchuk Jul 15, 2025
27e4a68
Track page count manually
ppinchuk Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion elm/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
ELM version number
"""

__version__ = "0.0.22"
__version__ = "0.0.23"
18 changes: 16 additions & 2 deletions elm/web/website_crawl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ def __init__(self, validator, file_loader_kwargs=None,
browser_config_kwargs=None, crawl_strategy_kwargs=None,
crawler_config_kwargs=None, cte_kwargs=None,
extra_url_filters=None, include_external=False,
url_scorer=None, max_pages=100):
url_scorer=None, max_pages=100, page_limit=None):
"""

Parameters
Expand Down Expand Up @@ -428,9 +428,16 @@ def __init__(self, validator, file_loader_kwargs=None,
:meth:`ELMLinkScorer.score` method to score the URLs.
By default, ``None``.
max_pages : int, optional
Maximum number of pages to crawl. By default, ``100``.
Maximum number of **successful** pages to crawl.
By default, ``100``.
page_limit : int, optional
Maximum number of pages to crawl regardless of success
status. If ``None``, a page limit of 2 * `max_pages` is
used. To set no limit (not recommended), use ``math.inf``.
By default, ``None``.
"""
self.validator = validator
self.page_limit = page_limit or 2 * max_pages

flk = {"verify_ssl": False}
flk.update(file_loader_kwargs or {})
Expand Down Expand Up @@ -510,10 +517,17 @@ async def run(self, base_url, termination_callback=None,
out_docs = []
should_stop = (termination_callback
or ELMWebsiteCrawlingStrategy.found_enough_docs)
page_count = 0
async with AsyncWebCrawler(config=self.browser_config) as crawler:
crawl_results = await crawler.arun(base_url, config=self.config)
async with aclosing(crawl_results) as agen:
async for result in agen:
page_count += 1
if page_count > self.page_limit:
logger.debug("Exiting crawl due to page limit")
break
if not result.success:
continue
results.append(result)
logger.debug("Crawled %s", result.url)
if on_result_hook:
Expand Down
Loading