Skip to content

Conversation

@ppinchuk
Copy link
Collaborator

Add a class to load local file asynchronously

@ppinchuk ppinchuk self-assigned this Oct 28, 2025
@ppinchuk ppinchuk added the enhancement New feature or request label Oct 28, 2025
@ppinchuk ppinchuk requested a review from Copilot October 28, 2025 02:29
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces asynchronous local file loading capabilities by refactoring the existing AsyncFileLoader into a more modular architecture with base and specialized classes.

Key Changes:

  • Refactored AsyncFileLoader into BaseAsyncFileLoader (abstract base), AsyncWebFileLoader (for web files), and AsyncLocalFileLoader (for local files)
  • Added AsyncFileLoader as a backward-compatibility alias for AsyncWebFileLoader
  • Version bumped from 0.0.31 to 0.0.32

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File Description
elm/web/file_loader.py Introduces base class hierarchy with BaseAsyncFileLoader and adds new AsyncLocalFileLoader for loading local PDF/HTML files; refactors AsyncWebFileLoader to extend the base class
tests/web/test_web_file_loader.py Updates tests to use AsyncWebFileLoader explicitly and adds new test cases for AsyncLocalFileLoader
elm/web/search/dux.py Updates documentation for backend parameter format
elm/version.py Bumps version to 0.0.32

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ppinchuk ppinchuk merged commit 7a5a8e4 into main Oct 28, 2025
15 checks passed
@ppinchuk ppinchuk deleted the pp/local_fl branch October 28, 2025 03:40
github-actions bot pushed a commit that referenced this pull request Oct 28, 2025
Add `AsyncLocalFileLoader`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant