-
Notifications
You must be signed in to change notification settings - Fork 25
Add AsyncLocalFileLoader
#76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces asynchronous local file loading capabilities by refactoring the existing AsyncFileLoader into a more modular architecture with base and specialized classes.
Key Changes:
- Refactored
AsyncFileLoaderintoBaseAsyncFileLoader(abstract base),AsyncWebFileLoader(for web files), andAsyncLocalFileLoader(for local files) - Added
AsyncFileLoaderas a backward-compatibility alias forAsyncWebFileLoader - Version bumped from 0.0.31 to 0.0.32
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| elm/web/file_loader.py | Introduces base class hierarchy with BaseAsyncFileLoader and adds new AsyncLocalFileLoader for loading local PDF/HTML files; refactors AsyncWebFileLoader to extend the base class |
| tests/web/test_web_file_loader.py | Updates tests to use AsyncWebFileLoader explicitly and adds new test cases for AsyncLocalFileLoader |
| elm/web/search/dux.py | Updates documentation for backend parameter format |
| elm/version.py | Bumps version to 0.0.32 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add `AsyncLocalFileLoader`
Add a class to load local file asynchronously