Functionalize resource module and add tests#221
Draft
paulf81 wants to merge 40 commits intoNatLabRockies:developfrom
Draft
Functionalize resource module and add tests#221paulf81 wants to merge 40 commits intoNatLabRockies:developfrom
paulf81 wants to merge 40 commits intoNatLabRockies:developfrom
Conversation
added 30 commits
February 26, 2026 13:48
…nto feature/clean_up_type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft PR is a first step towards addressed #210 . Rather then doing that all in one PR, thought a nicer thing is a PR that simply reorganizes what is already there in
hercules/resource/wind_solar_resource_downloader.pyinto smaller functions and add tests for those functions. Currently, the main means of checking the resourece modules are the examples inexamples/inputs, but if we chunk smaller operations into smaller functions, then all but the download itself can be tested with synthetic data. This can all be done without any changes that say effect the files inexamples/inputs.Note: this will look like more changes than it is until #216 is merged
Steps:
hercules/resource/wind_solar_resource_downloader.pyinto smaller functions, and those that can be applied to several relocate to a new filehercules/resource/resource_utilities.pyhercules/resource/resource_utilities.pythat do not download data