Merged
Conversation
lymereJ
reviewed
Aug 4, 2023
lib/openstudio-standards/standards/ashrae_90_1_prm/ashrae_90_1_prm.Model.rb
Outdated
Show resolved
Hide resolved
lymereJ
reviewed
Aug 4, 2023
...io_standards_data/test/database_files_from_json/system_requirement_energy_recovery_90_1.json
Outdated
Show resolved
Hide resolved
lymereJ
approved these changes
Aug 4, 2023
Collaborator
lymereJ
left a comment
lymereJ
left a comment
There was a problem hiding this comment.
I'll approved it but I think that the two small comments below should be addressed prior to merging.
…andards into appx_g/enhancement/model_identify_non_mech_cooled_systems
…ms' of https://github.com/NREL/openstudio-standards into appx_g/enhancement/model_identify_non_mech_cooled_systems
weilixu
deleted the
appx_g/enhancement/model_identify_non_mech_cooled_systems
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.