Skip to content

Comments

Apply Black to Python scripts#1600

Merged
mdahlhausen merged 1 commit intomasterfrom
apply_black_fmt
Sep 13, 2023
Merged

Apply Black to Python scripts#1600
mdahlhausen merged 1 commit intomasterfrom
apply_black_fmt

Conversation

@lymereJ
Copy link
Collaborator

@lymereJ lymereJ commented Sep 13, 2023

Pull request overview

Apply Black to format existing Python script to avoid failures in #1486.

Pull Request Author

  • Method changes or additions
  • Data changes or additions
  • Added tests for added methods
  • If methods have been deprecated, update rest of code to use the new methods
  • Documented new methods using yard syntax
  • Resolved yard documentation errors for new code (ran bundle exec rake doc)
  • Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
  • All new and existing tests passes
  • If the code adds new require statements, ensure these are in core ruby or add to the gemspec

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

@mdahlhausen mdahlhausen merged commit 8637313 into master Sep 13, 2023
@lymereJ lymereJ deleted the apply_black_fmt branch February 7, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants