replace EMS with AvailabilityManagerOptimumStart#1631
Open
replace EMS with AvailabilityManagerOptimumStart#1631
Conversation
Collaborator
Author
|
The majority of test failures are from object differences ("A OS:EnergyManagementSystem:ProgramCallingManager was found only in the before model", "A OS:AvailabilityManager:OptimumStart was found only in the after model") which are expected given this change. The performance test energy diff failures for SecondarySchool-90.1-2016-ASHRAE 169-2013-4A were investigated. The following differences were found in an annual run:
The overall HVAC system runtime increased by 2.4% with the modification, along with a slight drop in unmet cooling hours (250 -> 247). GIven the uncertainty in the modeled Availability Manager inputs for optimum start (as well as the original EMS implementation) I think these diffs are reasonable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
Replace the EMS implementation of optimum start AHU control with AvailabilityManager:OptimumStart
Pull Request Author
Review Checklist
This will not be exhaustively relevant to every PR.