Parametric Schedule Refactor#2088
Open
mdahlhausen wants to merge 30 commits intospace_type_refactorfrom
Open
Conversation
…io-standards into param_sch_refactor
EnergyPlus version 25.2 errors out if Plant Sizing is set to true in the simulation control object, but the model has no Sizing:Plant objects. NatLabRockies/EnergyPlus#11140 In model_run_sizing_run, do plant sizing if and only if there are Sizing:Plant objects in the model.
Clean up climate zone value getters/setters
- add schedule_parametric -> create_parametric_schedule - test data moved to test directory
- add doc arguments - remove require relative - remove test
temporarily ignore schedule_refactor directory for work on schedules
fix test schedule data formatting
- change model_derive_schedule_from_occupancy to create_derived_schedule_from_occupancy_schedule - remove model argument - make params optional - use explicit method from model_derive_equipment_schedule rather than create_complex_schedule() - remove model_derive_equipment_schedule as it is now redundant - remove artifact puts statements
- adjust the schedule derivation method to copy the rules of the occupancy schedule directly rather than matching by day type - move derived schedule parameters all into a hash that is passed in, rather than existing as a schedule format that is looked up from a .json file - change control points field from 'control_pts' to 'control_points' - fix bug in create_parametric_schedule_full to use the selected schedule name instead of the name of the first schedule in the schedule reference file - split out derive function into its own callable method - change schedule set for fire station sleeping quarters to just dormitory_living_quarters - add school schedule and derivation to the derived schedule tests
- add a new space_type_apply_parametric_internal_load_schedules method - default to this in create_typical, and add an option whether to use these schedules or the prototype schedules - add default parameteric occupancy schedules and parameters to derive other schedules from these parameters - fix an issue in schedule smoothing where if 24 was set as the end time it would duplicate with a [24.0, NaN] time-value pair - The default schedule parameters are placeholders for now. These need to be expanded (for gas and hot water equipment), and all schedule values need to be checked against previous schedules (occ, light, elec equip, gas equip, hot water)
creates a method to compare the two schedule versions - comstock prototype vs. parametric
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
This PR adds the parametric schedule pathway to the space type refactor. Lighting and equipment schedules are now derived from occupancy schedules.
Pull Request Author
bundle exec rake doc)bundle exec rake rubocop)Review Checklist