Merged
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (33.33%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
==========================================
+ Coverage 67.83% 67.85% +0.01%
==========================================
Files 40 40
Lines 7114 7111 -3
Branches 1044 1043 -1
==========================================
- Hits 4826 4825 -1
+ Misses 1959 1958 -1
+ Partials 329 328 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
github-actions bot
pushed a commit
that referenced
this pull request
Jun 2, 2025
Guard `getpass` call
github-actions bot
pushed a commit
to MRE-Code-Hub/rex
that referenced
this pull request
Jun 2, 2025
Guard `getpass` call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the documentation of
getpass.getuser, the call will throw anOSErroron systems without access to thepwdmodule. This means importingrexcan fail completely since we have agetpass.getusercall on import. In this PR, we delay the call togetpass.getuseruntil an HPC class instance is being created, allowingrexitself to be imported and used on systems missingpwd.