Skip to content

Comments

Fix MP for make SAM files function#223

Merged
ppinchuk merged 5 commits intomainfrom
pp/fix_mp_msf
Jun 6, 2025
Merged

Fix MP for make SAM files function#223
ppinchuk merged 5 commits intomainfrom
pp/fix_mp_msf

Conversation

@ppinchuk
Copy link
Collaborator

@ppinchuk ppinchuk commented Jun 6, 2025

Previously, make_SAM_files would overwrite the same file when num gids < num chunks. In this PR, we fix this by always adding a gid suffix if the user passes an iterable of GI's, even if that iterable only contains one value. The old behavior of not adding a suffix is preserved and explicitly tested for when the user intentionally passes a single GID (as an int) to the get_SAM_gid function.

@ppinchuk ppinchuk self-assigned this Jun 6, 2025
@ppinchuk ppinchuk added bugfix Fixes a bug p-high Priority: high topic-resource-handler Issues/pull requests related to the main rex Resource handler labels Jun 6, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.98%. Comparing base (65ca4a9) to head (482ad97).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
+ Coverage   67.85%   67.98%   +0.13%     
==========================================
  Files          40       40              
  Lines        7111     7113       +2     
  Branches     1043     1043              
==========================================
+ Hits         4825     4836      +11     
+ Misses       1958     1948      -10     
- Partials      328      329       +1     
Flag Coverage Δ
unittests 67.98% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
rex/resource_extraction/resource_extraction.py 85.73% <100.00%> (+1.28%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ppinchuk ppinchuk merged commit 2f1a224 into main Jun 6, 2025
17 of 19 checks passed
@ppinchuk ppinchuk deleted the pp/fix_mp_msf branch June 6, 2025 07:05
github-actions bot pushed a commit that referenced this pull request Jun 6, 2025
Fix MP for make SAM files function
github-actions bot pushed a commit to MRE-Code-Hub/rex that referenced this pull request Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixes a bug p-high Priority: high topic-resource-handler Issues/pull requests related to the main rex Resource handler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make_SAM_files() overwrites the same file due to no unique gid identifier for max_workers greater than 1

2 participants