Skip to content

Comments

fix multi fp file checking with glob patterns#226

Merged
grantbuster merged 1 commit intomainfrom
gb/glob_bug
Jul 23, 2025
Merged

fix multi fp file checking with glob patterns#226
grantbuster merged 1 commit intomainfrom
gb/glob_bug

Conversation

@grantbuster
Copy link
Member

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.99%. Comparing base (f185174) to head (56844b9).

Files with missing lines Patch % Lines
rex/utilities/utilities.py 50.00% 0 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #226   +/-   ##
=======================================
  Coverage   67.99%   67.99%           
=======================================
  Files          40       40           
  Lines        7114     7115    +1     
  Branches     1045     1045           
=======================================
+ Hits         4837     4838    +1     
  Misses       1948     1948           
  Partials      329      329           
Flag Coverage Δ
unittests 67.99% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
rex/utilities/utilities.py 47.77% <50.00%> (+0.14%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@grantbuster grantbuster requested a review from ppinchuk July 23, 2025 20:53
@grantbuster
Copy link
Member Author

@ppinchuk if you want to look feel free. simple. will merge in a day or two if I dont hear from you.

Copy link
Collaborator

@ppinchuk ppinchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! I've always thought the check for "*" was a bit too restrictive - glad it's more flexible now.

My only concern would have been for the remote files - what does glob do in those cases? But looks like the tests pass so I assume it does the expected thing of returning an empty list.

Thanks!!

@ppinchuk
Copy link
Collaborator

Do you need to bump version and/or release? Or is this just for your own env?

No worries if the latter, this can just be bundled in the next rex release, whenever that makes sense to do

@grantbuster
Copy link
Member Author

Yeah not sure why we did the * check. Lazy programming haha. Yeah glob returns an empty list if the string doesn't match anything.

Can just be left to the next release. I'm all good!

@grantbuster grantbuster merged commit 449b9fa into main Jul 23, 2025
19 checks passed
@grantbuster grantbuster deleted the gb/glob_bug branch July 23, 2025 21:00
github-actions bot pushed a commit that referenced this pull request Jul 23, 2025
fix multi fp file checking with glob patterns
github-actions bot pushed a commit to MRE-Code-Hub/rex that referenced this pull request Jul 23, 2025
fix multi fp file checking with glob patterns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants