fix multi fp file checking with glob patterns#226
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
=======================================
Coverage 67.99% 67.99%
=======================================
Files 40 40
Lines 7114 7115 +1
Branches 1045 1045
=======================================
+ Hits 4837 4838 +1
Misses 1948 1948
Partials 329 329
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@ppinchuk if you want to look feel free. simple. will merge in a day or two if I dont hear from you. |
ppinchuk
left a comment
There was a problem hiding this comment.
I like it! I've always thought the check for "*" was a bit too restrictive - glad it's more flexible now.
My only concern would have been for the remote files - what does glob do in those cases? But looks like the tests pass so I assume it does the expected thing of returning an empty list.
Thanks!!
|
Do you need to bump version and/or release? Or is this just for your own env? No worries if the latter, this can just be bundled in the next rex release, whenever that makes sense to do |
|
Yeah not sure why we did the * check. Lazy programming haha. Yeah glob returns an empty list if the string doesn't match anything. Can just be left to the next release. I'm all good! |
fix multi fp file checking with glob patterns
fix multi fp file checking with glob patterns
No description provided.