Separate vocabulary and language menus and detect language of text #21
+328
−164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juhoinkinen
changed the title
osma
requested changes
Mar 6, 2025
| var textract_base_url = 'https://ai.dev.finto.fi/textract/'//'http://localhost:8001/textract/'; | ||
| var textract_base_url = 'https://ai.dev.finto.fi/textract/' | ||
| } else { | ||
| // local development with VS Code Live Server extension - use APIs of Annif on localhost via Live Server proxy (overcomes CORS error by /v1/detect-language) |
There was a problem hiding this comment.
Do we want to have logic like this on the main branch?
(I'm fine either way, just asking whether this is intentional)
| }, | ||
| body: JSON.stringify({ | ||
| text: this.text, | ||
| languages: ["fi", "sv", "en"] // TODO Here should be only langs that selected project supports |
There was a problem hiding this comment.
Is the TODO a problem in practice for current Finto AI? For some vocabs, we don't support all languages.
| .then(response => response.json()) | ||
| .then(data => { | ||
| this.text_language = data.results[0].language; | ||
| // this.text_language_detection_score = data.results[0].score; TODO Add to tooltip |
There was a problem hiding this comment.
Is the TODO a problem? Should it be fixed now instead of leaving it like this?
| @@ -254,7 +323,9 @@ const mainApp = createApp({ | |||
| }) | |||
| .then(data => { | |||
| this.projects = data.projects | |||
| this.selected_project = this.projects[0].project_id | |||
| // Assume vocabulary id is a prefix of project id | |||
There was a problem hiding this comment.
Ideally, the vocab ID would be returned by the Annif REST API, but it doesn't expose it currently. I opened an issue about it on the Annif side.
| computed: { | ||
| disabledLanguages() { | ||
| // Map of languages and their enabling criteria based on vocabularyId | ||
| return { |
There was a problem hiding this comment.
Aren't the duplicate keys here problematic? Does this really work as intended?
Co-authored-by: Osma Suominen <osma.suominen@helsinki.fi>
Co-authored-by: Osma Suominen <osma.suominen@helsinki.fi>
Co-authored-by: Osma Suominen <osma.suominen@helsinki.fi>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the first menu from "Vocabulary and text language" (Annif project) to "Vocabulary" and adds a menu "Text language" (the Annif project is selected as a combination of the selected vocabulary and language). Thus, the text language can be selected independently of the vocabulary; when a vocabulary is selected, that does not have Annif projects for some languages, those language items are disabled in the languages menu.
Also adds automatic language detection, which updates the selection in the language menu. The language detection is run when
This PR branch is based on the branch of PR #18, so it's better to merge that to main before this. Closes #9.