pmd :: CollapsibleIfStatement #1061
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpdahlke
requested changes
Feb 11, 2025
| } | ||
| if ((rollingHash % (this.blockSize * 2)) == ((this.blockSize * 2) - 1) && this.fuzzLen2 < (SPAMSUM_LENGTH / 2 - 1)) { | ||
| this.fuzzHash2[this.fuzzLen2++] = b64EncodeLowBits(this.sumHash2); | ||
| this.sumHash2 = HASH_INIT; |
There was a problem hiding this comment.
Some of these I wonder if there is benefit to making them a method rather than jamming them in the above line. Here we have code that looks very similar to the above (line 185) where perhaps refactoring this would benefit more than just this line/warning.
| @@ -154,11 +154,9 @@ private long getIntervalInMillis() { | |||
| private boolean shouldRoll(long start) { | |||
| // verify both time and progress are set | |||
| // if we're below max we'll check the interval | |||
| if (period > 0 && max > 0 && progress.get() < max) { | |||
| if (period > 0 && max > 0 && progress.get() < max && ((start - lastRun + 100) < getIntervalInMillis())) { | |||
| // we fired a progress run or delayed start due to starvation. add 100 for clock skew | |||
There was a problem hiding this comment.
To make this read correctly with the comments, perhaps a method for the second if statement would be nicer?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves the pmd warnings, as well as the sonar complaints about these collapsible if statements