Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catching exception when decoding velocity values in MIDILike #210

Merged
merged 5 commits into from
Nov 30, 2024

Conversation

Natooz
Copy link
Owner

@Natooz Natooz commented Nov 30, 2024

Following #208


📚 Documentation preview 📚: https://miditok--210.org.readthedocs.build/en/210/

@Natooz Natooz added the bug Something isn't working label Nov 30, 2024
@Natooz Natooz added the enhancement New feature or request label Nov 30, 2024
Copy link

codecov bot commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.25%. Comparing base (9d9781c) to head (7e9c72b).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
src/miditok/tokenizations/midi_like.py 50.00% 2 Missing ⚠️
tests/utils_tests.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
- Coverage   90.65%   90.25%   -0.40%     
==========================================
  Files          40       41       +1     
  Lines        6011     6598     +587     
==========================================
+ Hits         5449     5955     +506     
- Misses        562      643      +81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Natooz Natooz merged commit 0f7c273 into main Nov 30, 2024
8 of 14 checks passed
@Natooz Natooz deleted the midilike-velocity-fix branch November 30, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant