Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[공통] ts-monorepo-template 를 최신화합니다. #10

Merged
merged 15 commits into from
Nov 18, 2024
Merged

[공통] ts-monorepo-template 를 최신화합니다. #10

merged 15 commits into from
Nov 18, 2024

Conversation

2-one-week
Copy link
Member

Related Issue

Describe your changes

  • ts-monorepo-template 를 최신화합니다.

    • pnpm 버전업
    • 불필요 size action 제거
    • naverpay changeset action으로 적용
    • code style 버전업
    • turbo 버전업
    • husky > lefthook
    • ts 버전업 (5.5 이상)

Request

@2-one-week 2-one-week self-assigned this Nov 14, 2024
@2-one-week 2-one-week requested a review from a team as a code owner November 14, 2024 08:47
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b73f5a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@npayfebot
Copy link

npayfebot commented Nov 14, 2024 •
edited
Loading

changeset-detect-add-actions

변경된 파일이 없습니다. commit을 확인해주세요.
packages_dir 지정이 안되어 있거나, markdown 파일만 변경점에 있다면, 탐지되지 않을 수 있습니다.

@keemhyunseok
Copy link

ci!

@2-one-week
Copy link
Member Author

@byhhh2 님

이거 eslint peer가 제대로 안깔리는데,,

image

음... root에다가 깔아야 하나요?

yceffort-naver
yceffort-naver reviewed Nov 14, 2024
View reviewed changes
.github/workflows/ci.yaml Outdated
Comment on lines 13 to 16
with:
version: 8
version: 9.1.1
run_install: true
- run: pnpm run prettier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요거 쓰지말고 대신 package.json의 engine 따라가게하실수 있을까여?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네잉

yceffort-naver
yceffort-naver reviewed Nov 14, 2024
View reviewed changes
package.json Outdated
Comment on lines 41 to 46
"packageManager": "pnpm@8.14.3"
"packageManager": "pnpm@9.1.1"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요거 저희 베이스 이미지 최신인 9.12.3으로 하시죠~

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네넵 그럼 이거 로컬에서 corepack enabled 처리 해야되는거죠??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node 도 22로 올릴까요?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네넵 그럼 이거 로컬에서 corepack enabled 처리 해야되는거죠??

네네 그리고 step 에 corepack enable 추가하시면 될듯

node 도 22로 올릴까요?

굿굿

@yceffort-naver
Copy link

eslint 도 올려야되는데..

@2-one-week
Copy link
Member Author

eslint 도 올려야되는데..

이거 아예 breaking change이던데.... 이번에 pite 만들면서 갈까요?

@yceffort-naver
Copy link

이거 아예 breaking change이던데.... 이번에 pite 만들면서 갈까요?

eslint 9 미만이 완전히 지원중단이 되서 대체를 해야하는데, 다른분꼐 부탁드리곘습니다.

@byhhh2
Copy link

byhhh2 commented Nov 15, 2024 •
edited
Loading

@byhhh2 님

이거 eslint peer가 제대로 안깔리는데,,

image

음... root에다가 깔아야 하나요?

@2-one-week 님!

이상하게.. peer 버전이 https://github.com/NaverPayDev/code-style/blob/main/packages/eslint-config/package.json#L22
8>= <9인데 9.14.0이 .. 깔렸네요 ?!

@2-one-week
Copy link
Member Author

@byhhh2 님

image

eslint 애들이 deprecated 처리해버리면서 최신으로 깔아버린 것 같습니다..?

@byhhh2
Copy link

byhhh2 commented Nov 18, 2024

@2-one-week 님
헐; 그렇군요 ㅠㅠ 버전업 빨리 해야겠네요 -_;;

@yceffort-naver
Copy link

@yongholeeme 갓 용 호

@2-one-week
Copy link
Member Author

일단 devDeps에 설치해서 caaefcd

이렇게 가볼게여

@byhhh2
Copy link

byhhh2 commented Nov 18, 2024

@2-one-week 님~

https://github.com/NaverPayDev/ts-monorepo-template/blob/main/.eslintrc
요기도 수정 가능하실까용?

@2-one-week
Copy link
Member Author

@byhhh2 님

오잉 어떻게 말씀이실까요?

@byhhh2
Copy link

byhhh2 commented Nov 18, 2024

@2-one-week 님!
typescript를 사용하면 좋을 것 같아요!

https://github.com/NaverPayDev/code-style/tree/main/packages/eslint-config#%EC%82%AC%EC%9A%A9-%EB%B0%A9%EB%B2%95

@2-one-week
Copy link
Member Author

예썰~0d78ea5

byhhh2
byhhh2 approved these changes Nov 18, 2024
View reviewed changes
Copy link

@byhhh2 byhhh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~~ 감사합니다 👍

@2-one-week
Copy link
Member Author

감삼다~

@2-one-week 2-one-week merged commit c6b1341 into main Nov 18, 2024
3 checks passed
@2-one-week 2-one-week deleted the repo/9_update branch November 18, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yceffort-naver yceffort-naver yceffort-naver left review comments

@byhhh2 byhhh2 byhhh2 approved these changes

Assignees

@2-one-week 2-one-week

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@2-one-week @npayfebot @keemhyunseok @yceffort-naver @byhhh2