Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for named external block #51

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

NiiRoZz
Copy link
Contributor

@NiiRoZz NiiRoZz commented Nov 23, 2024

Fix #50

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 91.07143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 76.60%. Comparing base (8bb3e0b) to head (0d82261).
Report is 2 commits behind head on named_external.

Files with missing lines Patch % Lines
src/NZSL/Ast/SanitizeVisitor.cpp 87.50% 3 Missing ⚠️
include/NZSL/Ast/Compare.inl 50.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           named_external      #51      +/-   ##
==================================================
+ Coverage           76.57%   76.60%   +0.03%     
==================================================
  Files                 158      158              
  Lines               21044    21090      +46     
  Branches             6206     6455     +249     
==================================================
+ Hits                16115    16157      +42     
- Misses               4834     4844      +10     
+ Partials               95       89       -6     
Files with missing lines Coverage Δ
include/NZSL/Ast/Nodes.hpp 45.45% <ø> (ø)
include/NZSL/Ast/SanitizeVisitor.hpp 100.00% <ø> (ø)
src/NZSL/Ast/Cloner.cpp 88.42% <100.00%> (+0.04%) ⬆️
src/NZSL/Ast/ReflectVisitor.cpp 93.06% <100.00%> (ø)
src/NZSL/GlslWriter.cpp 85.13% <100.00%> (ø)
src/NZSL/LangWriter.cpp 89.86% <100.00%> (+0.05%) ⬆️
src/NZSL/Parser.cpp 88.99% <100.00%> (+0.01%) ⬆️
src/NZSL/SpirvWriter.cpp 85.64% <100.00%> (ø)
tests/src/Tests/ErrorsTests.cpp 100.00% <ø> (ø)
tests/src/Tests/ExternalTests.cpp 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bb3e0b...0d82261. Read the comment docs.

if (identifierData)
{
auto variableValuePtr = HandleIdentifier(identifierData, node.identifiers.front().sourceLocation);
static_cast<VariableValueExpression*>(variableValuePtr.get())->prefix = identifierExpr.identifier;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really a fan of this one, and I'm not really sure how to tackle it correctly

@SirLynix SirLynix changed the base branch from main to named_external November 29, 2024 22:21
@SirLynix SirLynix merged commit 338ba89 into NazaraEngine:named_external Nov 29, 2024
47 checks passed
@SirLynix
Copy link
Contributor

Thank you!

@NiiRoZz NiiRoZz deleted the named_external branch November 29, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support for named external blocks
2 participants