-
Notifications
You must be signed in to change notification settings - Fork 2
Definition of Done
Garrett Allen edited this page May 22, 2019
·
1 revision
A sprint task will be considered done if the below listed criteria are met. A task is not to be released until all criteria are met.
- Meets all acceptance criteria enumerated on the issue card.
- All unit tests pass without warnings or errors.
- Code review has been completed with at least one other developer on the team.
A Sprint will be considered done if the below criteria are met.
- All tasks are linked to a PR
- All PRs are peer-reviewed
- All PRs for a milestone are squashed and merged
- Create tasks with "References #<>" in description, with a valid story number.
- Create new branch using name of task, e.g.
git checkout -b task1 - When all Acceptance Criteria are met for the Task, push the branch and create a PR,
git push -u origin task1. Then on GitHub, go to the "Code" tab and click create PR. In the description, place "References #<>" with a valid task ID - When PR has been reviewed and accepted, on GitHub, merge the branch using the "Squash and Merge" option. Enter "Implements #<>" with the id referenced in the PR description
- Delete the branch when merge is complete.
- Delete branch from local -
git checkout masterthengit branch -d task1