refactor: validate metadata asset_id matches map key#40
Open
respp wants to merge 1 commit intoNeko-Protocol:devfrom
Open
refactor: validate metadata asset_id matches map key#40respp wants to merge 1 commit intoNeko-Protocol:devfrom
respp wants to merge 1 commit intoNeko-Protocol:devfrom
Conversation
|
@respp is attempting to deploy a commit to the fabianalejandrosanchezduran-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
aguilar1x
approved these changes
Jan 31, 2026
Contributor
|
Any updates? |
respp
force-pushed
the
refactor/validate-metadata-asset-id
branch
from
d1507a6 to
92b6022
Compare
respp
force-pushed
the
refactor/validate-metadata-asset-id
branch
from
92b6022 to
fe71544
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32
I implemented a data integrity mechanism to prevent the contract from storing contradictory information. By adding this validation, I ensured that the external identifier (the map key) always matches the asset's internal identifier. This closes a vulnerability where an administrator—whether by error or malice—could register data for one asset (e.g., 'Tesla') under the name of another (e.g., 'Nvidia'), which would have caused critical failures for any downstream contract or application consuming the Oracle's data.
Tests:
stellar contract build --package rwa-oracle
cargo build --package rwa-oracle --target wasm32-unknown-unknown --release
cargo test --package rwa-oracle
