Develop sofi #314
Open
Develop sofi #314
+726
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SOFI buy/sell
.env.example SOFI
added 2fa processing and holdings command for sofi
I added Gabes addition of 3 more sms tries as well as it being able to handle both auth 2fa codes and sms 2fa codes
im losing it, i think this works good enough
|
found a bug when trying to sell, not ready yet |
Fixed selling issues
|
This should be ready. Features automatic 2FA log in, holdings, and buying/selling in live and dry mode. |
NelsonDane
requested changes
Aug 17, 2024
NEW SOFI using nodriver, instead of undetected chrome driver, which replaced base selenium nodriver made it possible to how hopefully bypass cloudflare by not even triggering it, as well as now sofi is quick and speedy from the time it logs in to the time it gets the account holdings.
Fixed the sms
buying function now works and made it a little faster
|
I adjusted the timeout for the sms element because 0 was just not enough time. I might recommend checking if an authy code is specified in the Also, talking about Authy, we might consider makng users put |
I did not mean to add a zery 🤦
fixed the selling and buy loop with the added function of dry mode handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 2fa processing as well as added a proper holdings fetch function