-
Notifications
You must be signed in to change notification settings - Fork 71
Add coefficient_ring for modules and series and improve the docs for base_ring
#2185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
45d9da8 to
62a69f3
Compare
62a69f3 to
27c43f3
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2185 +/- ##
==========================================
+ Coverage 87.93% 88.00% +0.07%
==========================================
Files 127 127
Lines 31802 32118 +316
==========================================
+ Hits 27964 28266 +302
- Misses 3838 3852 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for starting this! BTW I think we can also do something like this for series rings |
b10027b to
fb72432
Compare
fb72432 to
7dd8e29
Compare
coefficient_ring for modules and improve the docs for base_ringcoefficient_ring for modules and series and improve the docs for base_ring
|
Ok, I think we can merge this as it is now and resolve #2187 with a follow up and possibly breaking PR. |
This addresses #1207. Right now
base_ringandcoefficient_ringseem to be completely equivalent but with #2182 this will change. Depending on the merge order I can adjust this or the other PR to include an example (with universal polynomials) in the docs which clarifies the difference betweenbase_ringandcoefficient_ring.