Add _upgrade and _add_gens for mpolys
#2198
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #2182 and it replaces #2192. As discussed in #2193 and #2192 respectively, I haven't exported the two new methods. For now they are very specialized just for the current usecase of the universal polynomial ring and what will be become the universal ring. In the future
im_funcfrom OSCAR could be moved to AbstractAlgebra to replace_upgrade. Withim_funcit would theoretically be possible to perform some computations in smaller rings. Currently, if we have the polynomialsf=xandg=zin a universal polynomial ring, which was created with the only generatorxand later extended byyandz, their sum would be computed by mappingfandgto a multivariate polynomial ring inx,yandz. But withim_functhey could also be mapped to a multivariate polynomial ring in justxandz. With larger examples this could potentially decrease computation time.The diff to #2182 shouldn't be breaking.