Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename padics #1621

Merged
merged 8 commits into from
Jan 24, 2024
Merged

Rename padics #1621

merged 8 commits into from
Jan 24, 2024

Conversation

lgoettgens
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 110 lines in your changes are missing coverage. Please review.

Comparison is base (754f65c) 84.07% compared to head (d65308d) 84.12%.

Files Patch % Lines
src/HeckeMoreStuff.jl 3.77% 51 Missing ⚠️
src/flint/qadic.jl 74.24% 34 Missing ⚠️
src/flint/padic.jl 77.87% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1621      +/-   ##
==========================================
+ Coverage   84.07%   84.12%   +0.05%     
==========================================
  Files          93       93              
  Lines       36706    36725      +19     
==========================================
+ Hits        30859    30894      +35     
+ Misses       5847     5831      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgoettgens
Copy link
Collaborator Author

lgoettgens commented Jan 18, 2024

As there are some doctests in Oscar with a Vector{padic}, we might defer this PR to a breaking release. oscar-system/Oscar.jl#3196 and thofma/Hecke.jl#1356 are already prepared to fix everything there.

@lgoettgens lgoettgens mentioned this pull request Jan 23, 2024
12 tasks
@lgoettgens lgoettgens closed this Jan 23, 2024
@lgoettgens lgoettgens reopened this Jan 23, 2024
@thofma thofma merged commit 137ff57 into master Jan 24, 2024
14 of 15 checks passed
@thofma thofma deleted the lg/rename-padic branch January 24, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants