Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major Cleanup #31

Merged
merged 22 commits into from
Sep 16, 2024
Merged

Major Cleanup #31

merged 22 commits into from
Sep 16, 2024

Conversation

JonNesvold
Copy link
Contributor

Total revamp of Mrsal!

We have one boilerplate method (start_consumer) which we can refac later

Excpeted improvements:

  1. robustness
  2. clear exception handling
  3. sound retries
  4. flexibility for further developement (Stream, Federated connections, etc)
  5. Readability
  6. Maintainability

MartinRovang
MartinRovang approved these changes Sep 16, 2024
View reviewed changes
mrsal/amqp/subclass.py Outdated Show resolved Hide resolved
@JonNesvold JonNesvold merged commit b6d6224 into main Sep 16, 2024
3 checks passed
@JonNesvold JonNesvold deleted the cleanup branch September 16, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinRovang MartinRovang MartinRovang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonNesvold @MartinRovang