Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for compat. with latest ovos releases #600

Merged
merged 16 commits into from
Jan 2, 2024

Conversation

NeonDaniel
Copy link
Member

@NeonDaniel NeonDaniel commented Dec 29, 2023

Description

Replace deprecated imports
Update neon-utils to resolve ovos-workshop deprecation warnings
Update ovos-backend-client dependency to support latest releases
Deprecate patching of some skill classes in ovos-workshop

Issues

Other Notes

The refactoring in ovos-workshop means that fallback, common_query, and common_play skills will no longer have patches applied from neon-utils. This hasn't been fully tested but the following regressions may occur when using non-NeonSkill skills:

  • location will no longer use user profile data
  • get_response may not behave as expected in multi-user environments
  • speak/speak_dialog calls may not have the same timing context available and may not be compatible with server implementations
  • skill settings may not populate from settingsmeta.yml without a backend configured

@NeonDaniel NeonDaniel changed the title Resolve deprecation warnings Refactor for compat. with latest ovos releases Jan 2, 2024
@NeonDaniel NeonDaniel merged commit 260c2a0 into dev Jan 2, 2024
22 checks passed
@NeonDaniel NeonDaniel deleted the FEAT_ResolveDeprecated branch January 2, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant