Resolve issue with serializing default permissions #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `PermissionsConfig` to ensure default values are properly serialized
NeonDaniel
added a commit
to NeonGeckoCom/neon-hana
that referenced
this pull request
Dec 27, 2024
# Description Add default permissions for `users` to address serialization bug Explicitly handle old refresh tokens which fail Pydantic validation # Issues Includes a change to default user permissions to mitigate a serialization issue fixed in NeonGeckoCom/neon-data-models#10 # Other Notes <!-- Note any breaking changes, WIP changes, requests for input, etc. here -->
NeonBohdan
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add unit test to address observed permissions serialization issue
Update
PermissionsConfigto ensure default values are properly serializedIssues
Other Notes
Issue observed in alpha and beta deployments of the
neon-users-servicewhen creating new users with default settingsSolution found in pydantic/pydantic#7757