Update UserDbRequest models #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeonDaniel
force-pushed
the
FEAT_UpdateUserDbCRUDOperations
branch
2 times, most recently
from
367fb53 to
66d5bbf
Compare
NeonDaniel
force-pushed
the
FEAT_UpdateUserDbCRUDOperations
branch
from
66d5bbf to
532e288
Compare
Update TokenConfig model to reflect expected database schema Refactor AccessRoles values to allow for more in-between values Add methods to read/dump PermissionsConfig to JWT-compatible role strings
…omment Update unit test to account for token config change
Add test coverage for TokenConfig
Refactor `HanaToken` to include params previously used in `TokenConfig`
Maintains compat. with users service by determining model based on the requested `operation`
… admin-authenticated changes Finish test coverage for MQ user database CRUD models
Update raised exception to use exact keys
… any read operation Define "READ_USERS" role and annotate special roles
Validate passed token as an access token, rather than refresh
Annotate config values in PermissionsConfig to describe application of permissions Add a `users` permission to define access to the users service independent of the rest of the backend (matches `node` and `llm` behavior)
NeonDaniel
force-pushed
the
FEAT_UpdateUserDbCRUDOperations
branch
from
532e288 to
131c5fa
Compare
… already define read and write access, respectively
Add import tests to ensure all imports resolve
NeonDaniel
force-pushed
the
FEAT_UpdateUserDbCRUDOperations
branch
from
98fc370 to
d4bd68a
Compare
Refactor tests to resolve issue with reloading base classes
mikejgray
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors
UserDbRequestinto seprate schemas for CRUD operationsMaintains compat. with users service by determining model based on the requested
operationAdds a
userspermissions config and annotatesPermissionsConfigvaluesIssues
Other Notes
Needs to be rebased on
devafter merge of #2