Implement models for BrainForge service #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a" BrainForge personas
Add `LLMGetInference.as_llm_request` convenience method
NeonBohdan
reviewed
Dec 23, 2024
NeonBohdan
reviewed
Dec 23, 2024
NeonBohdan
reviewed
Dec 23, 2024
NeonBohdan
reviewed
Dec 23, 2024
NeonBohdan
reviewed
Dec 23, 2024
NeonBohdan
reviewed
Dec 23, 2024
NeonBohdan
reviewed
Dec 23, 2024
|
|
||
|
|
||
| class LLMGetModelsHttpResponse(BaseModel): | ||
| models: List[BrainForgeLLM] |
There was a problem hiding this comment.
This returns both all models and all personas, making Persona related requests useless
There was a problem hiding this comment.
Maybe the brainforge_get_personas endpoint isn't necessary at all? The only use case I see for it now is if some client wants to get a specific model@revision without parsing all of the available models
There was a problem hiding this comment.
I think that it will never be the case
Because every service wants to request all available info at once and validate requests before been sent
But we can keep it, and deside later
… handling Refactor tokenizer model names to be more descriptive
NeonBohdan
reviewed
Dec 24, 2024
NeonBohdan
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement models for LLM MQ requests/responses
Implement models for LLM requests via HANA endpoints
Issues
Adds incoming user query to
historyinLLMRequest.to_completion_kwargs. Missed in #4Other Notes