Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create ingress-common charts #53

Conversation

mikejgray
Copy link

Description

Creates by default, with a flag to skip creation of nginx ingress.

Creates by default, with a flag to skip creation of nginx ingress.
@NeonDaniel
Copy link
Member

Looking at this now, I see the ingress charts are published as ingress-common so maybe a simpler solution would be to update docs to apply the chart from the helm repo directly? helm install diana/ingress-common should do it

@mikejgray
Copy link
Author

Looking at this now, I see the ingress charts are published as ingress-common so maybe a simpler solution would be to update docs to apply the chart from the helm repo directly? helm install diana/ingress-common should do it

So rather than dropping everything off in the output folder, just helm install from the repo's copy since there's nothing to configure?

@NeonDaniel
Copy link
Member

Looking at this now, I see the ingress charts are published as ingress-common so maybe a simpler solution would be to update docs to apply the chart from the helm repo directly? helm install diana/ingress-common should do it

So rather than dropping everything off in the output folder, just helm install from the repo's copy since there's nothing to configure?

That's my thinking. It also means we don't have to worry about updating charts in the output directory if the ingress chart is updated

@NeonDaniel NeonDaniel deleted the branch NeonGeckoCom:FEAT_ResourceAnnotations November 30, 2023 22:11
@NeonDaniel NeonDaniel closed this Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants