Initial Service Implementation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define `AccessRoles` enum Define exceptions for user existence errors Define database ABC with documented methods
Add models module test coverage
Remove invalid Docker test automation Fix typo in unit test package installation
Fix check for existing username/user_id Move user conflict check to internal method in base class
Implement minimal `service.py` with default configuration and ovos-config configuration handling Document configuration structure
…ation Add `create_user` method with added check for input passwords being hashed with unit tests
Implement `authenticate_user` method with unit test coverage and an AuthenticationError
Add separate method for reading user entries without authentication data Add helpers for update/delete operations that perform some degree of input validation Add unit test coverage for changes
Update exception in `delete_user` to be more specific
Update `TokenConfig` to match/extend existing config used in neon-hana Update MQ error handling to return HTTP codes for HANA integration
Accept `access_token` in `MQRequest` model as an alternate auth method
Implement unit test automation with config from GHA secrets
Remove created test collections after unit test run
Update Dockerfile to include MongoDB dependency
TODO
|
Prevent update requests from modifying users without validating a token or password Prevent update requests from allowing an escalation of privileges
Refactor MQ handling to parse specific request models for UserDB CRUD
mikejgray
reviewed
Nov 18, 2024
… already define read and write access, respectively
Resolve syntax warnings in Dockerfile
|
This is ready for review; the only remaining task is to define a license, but otherwise this is complete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Defines configuration structure as Pydantic objects
Defines an abstract Database class with an SQLite implementation
Includes packaging, unit tests, and automation
Issues
NeonGeckoCom/neon-hana#5
NeonGeckoCom/neon-hana#7
NeonGeckoCom/neon-hana#10
NeonGeckoCom/neon-hana#29
Rebase on NeonGeckoCom/neon-data-models#1
First application NeonGeckoCom/neon-hana#33
Other Notes
Module outlined in this gist
The service methods wrap underlying database CRUD with some added logic to perform input validation and to prevent accidental access to sensitive configuration and accidental deletion.