Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Skill base classes #480

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Update Skill base classes #480

merged 3 commits into from
Oct 24, 2023

Conversation

NeonDaniel
Copy link
Member

Description

Troubleshoot FallbackSkill inheritance
Update CommonQuerySkill to extend ovos_workshop implementation
Mark CommonPlaySkill as deprecated

Issues

Other Notes

Update CommonQuerySkill to extend ovos_workshop implementation
Mark CommonPlaySkill as deprecated
@NeonDaniel NeonDaniel marked this pull request as ready for review October 24, 2023 23:09
@NeonDaniel NeonDaniel merged commit d20662f into dev Oct 24, 2023
@NeonDaniel NeonDaniel deleted the FIX_SkillClassInheritance branch October 24, 2023 23:11
@github-actions github-actions bot mentioned this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant