Improve connection close and error handling #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to match `BlockingConsumerThread` Handle channel/connection closed exceptions explicitly in `SelectConsumerThread`
NeonDaniel
changed the title
error_func to match BlockingConsumer…y once Update tests to check for expected error callbacks
NeonKirill
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
SelectConsumerThreadto pass exceptions toself.error_functo matchBlockingConsumerThreadHandle channel/connection closed exceptions explicitly in
SelectConsumerThreadUpdate
BlockingConsumerThreadto ensure connection is closed exactly onceUpdate tests to check for expected error callbacks
Issues
Alternate solution to #106
Other Notes