Update param name to avoid conflict with threading.Thread
#120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sses that also extend `Thread`
Merged
NeonDaniel
added a commit
that referenced
this pull request
Feb 4, 2025
# Changelog ## [0.7.2a21](https://github.com/NeonGeckoCom/neon_mq_connector/tree/0.7.2a21) (2025-01-27) [Full Changelog](0.7.2a20...0.7.2a21) **Merged pull requests:** - Update to ensure `message_id` is not None [\#121](#121) ([NeonDaniel](https://github.com/NeonDaniel)) ## [0.7.2a20](https://github.com/NeonGeckoCom/neon_mq_connector/tree/0.7.2a20) (2025-01-24) [Full Changelog](0.7.2a19...0.7.2a20) **Merged pull requests:** - Update param name to avoid conflict with `threading.Thread` [\#120](#120) ([NeonDaniel](https://github.com/NeonDaniel)) ## [0.7.2a19](https://github.com/NeonGeckoCom/neon_mq_connector/tree/0.7.2a19) (2025-01-24) [Full Changelog](0.7.2a18...0.7.2a19) **Merged pull requests:** - Handle RMQ checks with default vhost [\#119](#119) ([NeonDaniel](https://github.com/NeonDaniel)) ## [0.7.2a18](https://github.com/NeonGeckoCom/neon_mq_connector/tree/0.7.2a18) (2025-01-23) [Full Changelog](0.7.2a17...0.7.2a18) **Merged pull requests:** - Improved Startup Connectivity Checks [\#117](#117) ([NeonDaniel](https://github.com/NeonDaniel)) ## [0.7.2a17](https://github.com/NeonGeckoCom/neon_mq_connector/tree/0.7.2a17) (2025-01-23) [Full Changelog](0.7.2a16...0.7.2a17) **Merged pull requests:** - Update copyright notices to 2025 [\#118](#118) ([NeonDaniel](https://github.com/NeonDaniel)) ## [0.7.2a16](https://github.com/NeonGeckoCom/neon_mq_connector/tree/0.7.2a16) (2025-01-23) [Full Changelog](0.7.2a15...0.7.2a16) **Merged pull requests:** - Support Select Connections in `emit_mq_message` [\#115](#115) ([NeonDaniel](https://github.com/NeonDaniel)) ## [0.7.2a15](https://github.com/NeonGeckoCom/neon_mq_connector/tree/0.7.2a15) (2025-01-23) [Full Changelog](0.7.2a14...0.7.2a15) **Merged pull requests:** - Update default async consumer behavior and configuration [\#113](#113) ([NeonDaniel](https://github.com/NeonDaniel)) ## [0.7.2a14](https://github.com/NeonGeckoCom/neon_mq_connector/tree/0.7.2a14) (2025-01-22) [Full Changelog](0.7.2a13...0.7.2a14) **Merged pull requests:** - Handle errors if MQ is not connected at service launch [\#116](#116) ([NeonDaniel](https://github.com/NeonDaniel)) ## [0.7.2a13](https://github.com/NeonGeckoCom/neon_mq_connector/tree/0.7.2a13) (2025-01-17) [Full Changelog](0.7.2a12...0.7.2a13) **Merged pull requests:** - Update logging in select consumer close [\#112](#112) ([NeonDaniel](https://github.com/NeonDaniel)) ## [0.7.2a12](https://github.com/NeonGeckoCom/neon_mq_connector/tree/0.7.2a12) (2025-01-16) [Full Changelog](0.7.2a11...0.7.2a12) **Merged pull requests:** - Resolve observed connection errors [\#111](#111) ([NeonDaniel](https://github.com/NeonDaniel)) ## [0.7.2a11](https://github.com/NeonGeckoCom/neon_mq_connector/tree/0.7.2a11) (2025-01-14) [Full Changelog](0.7.2a10...0.7.2a11) **Merged pull requests:** - Define `shutdown` method for NeonMQHandler with unit test coverage [\#110](#110) ([NeonDaniel](https://github.com/NeonDaniel)) ## [0.7.2a10](https://github.com/NeonGeckoCom/neon_mq_connector/tree/0.7.2a10) (2025-01-13) [Full Changelog](0.7.2a9...0.7.2a10) **Merged pull requests:** - Fix ` reconnection` with unit test coverage [\#109](#109) ([NeonDaniel](https://github.com/NeonDaniel)) ## [0.7.2a9](https://github.com/NeonGeckoCom/neon_mq_connector/tree/0.7.2a9) (2025-01-02) [Full Changelog](0.7.2a8...0.7.2a9) **Merged pull requests:** - Improve connection close and error handling [\#107](#107) ([NeonDaniel](https://github.com/NeonDaniel)) ## [0.7.2a8](https://github.com/NeonGeckoCom/neon_mq_connector/tree/0.7.2a8) (2024-12-11) [Full Changelog](0.7.2a7...0.7.2a8) **Merged pull requests:** - Update tests to use temporary RMQ instance and improve coverage [\#104](#104) ([NeonDaniel](https://github.com/NeonDaniel)) ## [0.7.2a7](https://github.com/NeonGeckoCom/neon_mq_connector/tree/0.7.2a7) (2024-12-05) [Full Changelog](0.7.2a6...0.7.2a7) **Merged pull requests:** - \[Bug Fix\] Fixing issue with reopenning connection on consumers [\#103](#103) ([NeonKirill](https://github.com/NeonKirill)) ## [0.7.2a6](https://github.com/NeonGeckoCom/neon_mq_connector/tree/0.7.2a6) (2024-12-05) [Full Changelog](0.7.2a5...0.7.2a6) **Merged pull requests:** - Eliminated "self joining" problem in consumer threads and added graceful restarts handling [\#102](#102) ([NeonKirill](https://github.com/NeonKirill)) ## [0.7.2a5](https://github.com/NeonGeckoCom/neon_mq_connector/tree/0.7.2a5) (2024-12-03) [Full Changelog](0.7.2a4...0.7.2a5) **Merged pull requests:** - \[BUG FIX\] Fixing Async Consumer Logic to work based on SelectConnection [\#100](#100) ([NeonKirill](https://github.com/NeonKirill)) ## [0.7.2a4](https://github.com/NeonGeckoCom/neon_mq_connector/tree/0.7.2a4) (2024-11-21) [Full Changelog](0.7.2a3...0.7.2a4) **Implemented enhancements:** - \[FEAT\] Update tests to run without org secrets [\#97](#97) **Merged pull requests:** - \[FEAT\] Async-based Consumers Support [\#99](#99) ([NeonKirill](https://github.com/NeonKirill)) ## [0.7.2a3](https://github.com/NeonGeckoCom/neon_mq_connector/tree/0.7.2a3) (2024-09-12) [Full Changelog](0.7.2a2...0.7.2a3) **Merged pull requests:** - Update OVOS dependencies [\#98](#98) ([NeonDaniel](https://github.com/NeonDaniel)) ## [0.7.2a2](https://github.com/NeonGeckoCom/neon_mq_connector/tree/0.7.2a2) (2024-04-25) [Full Changelog](0.7.2a1...0.7.2a2) **Merged pull requests:** - feat: allow ovos-utils 0.1.0 [\#96](#96) ([mikejgray](https://github.com/mikejgray)) ## [0.7.2a1](https://github.com/NeonGeckoCom/neon_mq_connector/tree/0.7.2a1) (2024-03-30) [Full Changelog](0.7.1...0.7.2a1) **Fixed bugs:** - Fixing Issues with Consumers termination [\#95](#95) ([NeonKirill](https://github.com/NeonKirill)) \* *This Changelog was automatically generated by [github_changelog_generator](https://github.com/github-changelog-generator/github-changelog-generator)*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor
_startedto_consumers_startedto avoid conflicts in classes that also extendThreadIssues
Other Notes
Observed in an alpha deployment testing NeonGeckoCom/neon-iris#67