-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data review tool testing and Logging #64
Conversation
Merge Dev to Main: Updated Release for xDD Team Docker Review
Merge Dev to Main for Initial Data Product Share with Sponsor
…xtractor into data-review-tool-testing
…xtractor into data-review-tool-testing
import dash_player as dp | ||
|
||
sys.path.append(os.path.join(os.path.dirname(__file__), "..", "..")) | ||
|
||
from src.data_review_tool.pages.config import * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: generally better to import specific functions instead of import all, suspect this is because there are a lot so it makes sense to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, looks good, samll comment on import * usage but thnk it's the right use case
Added: