Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data review tool testing and Logging #64

Merged
merged 23 commits into from
Jun 26, 2023
Merged

Conversation

shaunhutch
Copy link
Collaborator

Added:

  • Testing
  • Logging
  • Extra sentences prior and after

@shaunhutch shaunhutch self-assigned this Jun 23, 2023
@shaunhutch shaunhutch marked this pull request as ready for review June 23, 2023 18:34
import dash_player as dp

sys.path.append(os.path.join(os.path.dirname(__file__), "..", ".."))

from src.data_review_tool.pages.config import *
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: generally better to import specific functions instead of import all, suspect this is because there are a lot so it makes sense to me!

Copy link
Collaborator

@tieandrews tieandrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looks good, samll comment on import * usage but thnk it's the right use case

@tieandrews tieandrews merged commit b9e2415 into dev Jun 26, 2023
@tieandrews tieandrews deleted the data-review-tool-testing branch June 26, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants