Remove timestamps from PeerStanding
#474
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't repeat the logic for testing whether peer standing is bad. Use one canonical method instead. Also: - improve documentation of command line argument `peer_tolerance` - prevent non-sensical peer tolerances from entering the application - improve code flow by staying on the happy path more - adhere to max line length more often - move test code into test module
The struct `PeerStanding` records the most recent reward and the most recent punishment. Previously, it recorded the time of the respective event. This time was never used. Now, the time is no longer recorded.
jan-ferdinand
force-pushed
the
jfs/is_standing_bad_deduplicate_pr
branch
from
a94a3d8 to
bfa0896
Compare
|
I think the timestamp could be very valuable for debugging purposes -- as it allows you to go into the logs and see what caused the negative sanction. So I'd rather open an issue to make use of this timestamp in e.g. the dashboard. Also: The CLI command |
jan-ferdinand
force-pushed
the
jfs/is_standing_bad_deduplicate_pr
branch
2 times, most recently
from
801e21e to
d69be6c
Compare
|
Closing in favor of #475, which suggests that the timestamps should be used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The struct
PeerStandingrecords the most recent reward and the most recent punishment. Previously, it recorded the time of the respective event. This time was never used. Now, the time is no longer recorded.This is a breaking change because struct
PeerStandingis public, and so are the modified fields.Note that this PR builds on top of #469.