Make clippy more pedantic #484
Draft
+362
−329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-ferdinand
changed the title
changelog: ignore
changelog: ignore
Usually, this means deriving. Manual implementations are the exception. changelog: ignore
changelog: ignore
changelog: ignore
The pattern `if foo { return; } else { bar(); }` is more canonically
expressed as `if foo { return; } bar();`
changelog: ignore
It is easier to read `if foo { bar() } else { baz() }` than it is to
read `if !foo { baz() } else { bar() }`.
changelog: ignore
changelog: ignore
changelog: ignore
changelog: ignore
jan-ferdinand
force-pushed
the
jfs/more_pedantic_clippy_pr
branch
from
dad46b0 to
dd08e41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix common stylistic oddities.
Each commit fixes one lint (or a small number of identical-in-spirit lints) to simplify their reversion, in case there are controversies.