Skip to content

Add iView, SBS, 10Play, Reshet13, 7Plus, Tubi, 9Now #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2025
Merged

Conversation

amitkeret
Copy link
Contributor

Adding multiple sources and their icons.
SVG paths are all optimised, relative values and minified to save space.
image

Re: testing:
These icons and activity values were all tested vie the UI, by adding custom icons/actions, and using them in my layout.
I was unable, however, to test the actual compiled JS file. I kept loading the latest master release version instead.
Steps I took:

  • Fork, git clone, npm install
  • update relevant files on dev branch, npx build
  • tried overwriting the min.js file on my HA installation via SSH > no good
  • removed original repo, downloaded my fork, used HACS' install action to update to dev branch > no good

I'm sorry to say I'm not sure why this happened...
Any guidance on how to test the code would be welcome. Otherwise, please see the files themselves for icons/sources.

@Nerwyn
Copy link
Owner

Nerwyn commented Feb 21, 2025

Thanks for your contribution!

FYI the build pipeline can be run using the command npm run build, which is a npm package.json script for the command npx webpack. If you run the command npm run setup, it'll setup pre-commit which will run the githooks/pre-commit bash script. I should add a little blurb for this in the README.

I haven't figured out how to get Home Assistant to recreate the gzipped JS file it normally serves, which is why I often use alpha builds for development since it's much faster to push it to my dev branch, create and alpha build, and install that using HACS than it is fight Home Assistant's caching. I did find this thread with a possible solution for local development that I'm going to try out.

I've checked all of the icons as custom icons and they look great! To be honest a lot of the custom icons that exist could use minification if you ever want to take a stab at those in the future.

@Nerwyn Nerwyn merged commit 6368ae6 into Nerwyn:dev Feb 21, 2025
1 check passed
@Nerwyn
Copy link
Owner

Nerwyn commented Feb 21, 2025

The instructions in that thread worked! I'll add gzipping to the build pipeline, but add the min.js.gz file to .gitignore and include it in the contributing instructions in the README.

@Nerwyn
Copy link
Owner

Nerwyn commented Feb 21, 2025

Released in 4.3.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants