Add record ref for accounting period to item_fulfillment #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add update list
iloveitaly
reviewed
Feb 5, 2019
| @@ -11,12 +11,12 @@ class ItemFulfillment | |||
|
|
|||
| fields :tran_date, :tran_id, :shipping_cost, :memo, :ship_company, :ship_attention, :ship_addr1, | |||
| :ship_addr2, :ship_city, :ship_state, :ship_zip, :ship_phone, :ship_is_residential, | |||
| :ship_status, :last_modified_date, :created_date | |||
| :ship_status, :last_modified_date, :created_date, :created_from_ship_group | |||
There was a problem hiding this comment.
@marianmosley could you extract all of the field additions into a separate PR for review?
There was a problem hiding this comment.
@marianmosley friendly reminder here!
iloveitaly
force-pushed
the
master
branch
2 times, most recently
from
7185ffc
to
df796ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With multiple accounting periods open, NetSuite defaults to the earliest period open, rather than the latest. This allows the posting period to be specified when creating an item_fulfillment.