Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependence on Object#blank? monkey patch #607

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove dependence on Object#blank? monkey patch #607

wants to merge 1 commit into from

Commits on Mar 6, 2024

  1. Remove dependence on Object#blank? monkey patch 

    Nori patched `Object` to implement a `blank?` method, however it was
removed in v2.7 (February 2024), so uses within this gem were now
breaking without the method being implemented.

Nori commit:
savonrb/nori@780d01d

CI was passing for Ruby < 3, since Nori v2.7 requires Ruby 3, however
Ruby >= 3 was failing once it started using Nori v2.7.
    @cgunther
    cgunther committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    faa792a View commit details
    Browse the repository at this point in the history