CD-6394 add klass #612
Open
CD-6394 add klass #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WHY: previously could not utilize soap action attach This adds the attach basic reference functionality into the gem
[CLOUD-737-attach-functionality]
Why: When adding a file from a workflow, even though it will sometimes be 'succuessful' it was still returning a 500 to the platform This change addresses the need by: made an update to the gem to return true/200 if a file is created and to return the file name if it is successfully created so we can query file by that attribute to create attachment Ticket [CLOUD-737]
[hotfix-CLOUD-737]
Why: * no nested if else statements! This change addresses the need by: * learned about try Ticket * [CLOUD-]
[HOTFIX-CLOUD-737-add-action-for-file]
*WHY The sales order record did not have the intercompany transaction field or the intercompany status field *This addresses the need by Adding those fields to the sales order record -caveat: I tried to test this with multiple payloads provided by the automation engineer but have yet to get a successful post. I have communicated the two errors we are getting, either a permission error or wrong enity for record depending on how the payload is formatted. The automation engineer is checking with customer, so I'm not sure if we want to wait to merge this in until the errors have been confirmed or not. [CLD-597]
Why:
*The expense report object did not exist in the netsuite ruby gem or in our connector
This change addresses the need by:
*updating the gem and connector to include the expense report object. This ticket is dependent on the pr for branch cld-571 in the netsuite ruby connector
Ticket
* [CLD-571]
[CLD-597-intercompany-updates]
[CLD-571-expense-report]
*Why: Inventory subsidiary and inventory location were not present fields on the sales order line item *This change addresses the need by: Added those two fields
[CLD-659-sales-order-lines]
*Why: The vendor credit object in the gem previously had record reference fields defined differently than the majority of the other objects in the gem. Because of this, when we call '.record_refs' in the connector, it was erroring *This addresses the change by: Adding in the record ref support and redefined how the record reference fields are defined. [CLD-669]
[CLD-669-vendorcredit-record-refs]
Why: *The purchase order expenses were not supported within the gem, so they were being returned in the soap response but not in the json response returned by the gem. With this object missing, it would not have allowed posting a purchase order with an expense list either. This change addresses the need by: *Added the purchase order expense list record and the purchase order expense record Ticket * [CLD-725]
[CLD-725-expenses-on-purchaseorders]
Why: *There was not support for expense lines to show up on item receipts in Netsuite This change addresses the need by: *added in the item receipt expense list and item receipt expense models to the gem Ticket * [CLD-737]
[CLD-737-item-receipt-expenses]
Why: *expense categories were needed for posting an expense report This change addresses the need by: *adding in the expense category record to support searching for expense category Ticket * [CLD-756]
[CLD-756-Add-Expense-Categories]
*Why: We were experiencing 500s when making certain requests to netsuite and needed to accomodate them *How: Increased the timeout when configuring the savon client [CLD-882]
[CLD-882-large-response]
*Why: The gem previously supported versions up to 2018 but later versions were not supported *How: Updated the netsuite savon config to set the wsdl and the endpoint level [CLD-878]
[CLD-878 Update config for versions]
*Why: Earlier versions of netsuite did not have the field class on the vendor credit expense line level or the vendor credit item line level *This addresses the need by: Added the class field to both the vendor credit expense record class and the vendor credit item record class. Added the methods to those classes required for setting the record references appropriately [CLD-917]
[CLD-917-vendor-credit-klass]
add-item-record-type
Why Not all classes have or need a `klass` attribute
fix-nme-Attributes-method
Why version 2015 has been yanked. Updating the default to 2016_2
…version update-default-netsuite-api-version
[CD-4491] Adding async add list action
small changes on async_add_list method
…esponse-errors Commenting out the code in the response_errors method
…sponse return raw response
commenting out parsing of response
making class variable
Backing up a step
commenting out response_errors
simplify responses
…lerts [CD-4737] Upgraded gems to resolve security vulnerabilities
2016 doesn't work
update-default-version-to-2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.