add 2014_1 wsdl, make search results work when there is only a single result on a page #82
Conversation
…ult set (look for an array, and if it's not one make it one)
| @@ -23,7 +23,7 @@ def initialize(response, result_class) | |||
| if response.body.has_key?(:record_list) | |||
| # basic search results | |||
| record_list = response.body[:record_list][:record] | |||
| record_list = [record_list] if @total_records == 1 | |||
| record_list = [record_list] unless record_list.is_a?(Array) | |||
There was a problem hiding this comment.
I'm curious... why was this needed? What situation broke the existing implementation?
There was a problem hiding this comment.
When you have more than one page of items and the last page has only a single item.
There was a problem hiding this comment.
Ahh, got it. Nice catch! Merged this into master.
|
Thanks for the PR! I was considering removing the static WSDLs from the gem completely. Do you find the static WSDLs useful? Why do you find using them helpful as opposed to just pointing to the NS hosted WSDLs? |
|
Not really (honestly, I don't even know how they are used). Just included On Thu, Jun 19, 2014 at 7:33 PM, Michael Bianco notifications@github.com
|
Ensure that response.body has :search_row_list AND that the value is not itself null
|
any intention of merging this? Happy to make any changes, just let me know. |
|
Could you remove the 2014_1 WSDL? I'd like to get this merged, just haven't had enough time to take a deeper look. Hopefully I'll have time soon! |
|
Done! I also:
Let me know if you have questions, would love to have this merged in |
| attributes[:ssl_ca_cert_file] | ||
| end | ||
| end | ||
|
|
||
| def api_version(version = nil) |
There was a problem hiding this comment.
Why were these additional SSL configuration options needed? I'm hesitant to merge them in unless there is a strong general use case.
|
Whoa, sorry about the delay on this! Merged in some of the commits here with 5faab91...64e8a17 Couple other notes:
|
No description provided.