libatalk: create utility function convert_utf8_to_mac() #2507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdmark
force-pushed
the
2466-the-utompath-function-is-repeated-in-multiple-modules
branch
from
4f39db4 to
3e83784
Compare
The convert_utf8_to_mac() function is based on utompath() which is implemented in etc/afpd/desktop.c but of a simpler, earlier form In comparison, utompath() can handle other input charsets than UTF-8, while also doing Mac filename mangling after charset conversion As a side note, utompath() in etc/afpd/desktop.c cannot easily be moved to libatalk since the mangling logic also sits in the afpd code, and has deep coupling with other afpd logic such as dirlookup(). A much larger refactoring would be needed here.
rdmark
force-pushed
the
2466-the-utompath-function-is-repeated-in-multiple-modules
branch
from
e141cd5 to
ee9cbef
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The convert_utf8_to_mac() function is based on utompath() which is implemented in etc/afpd/desktop.c but of a simpler, earlier form – we remove two duplicated implementations in nad and dbd respectively
In comparison, utompath() can handle other input charsets than UTF-8, while also doing Mac filename mangling after charset conversion
As a side note, utompath() in etc/afpd/desktop.c cannot easily be moved to libatalk since the mangling logic also sits in the afpd code, and has deep coupling with other afpd logic such as dirlookup(). A much larger refactoring would be needed here.