Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper methods to the TypesafeConfigReader. #440

Open
wants to merge 4 commits into
base: 2.x
Choose a base branch
from

Conversation

gorzell
Copy link
Contributor

@gorzell gorzell commented Sep 2, 2016

I added some helper methods and tests for them. There is probably a large issue around how to support this kind of thing in the interface, but I figure this was a good start.

@gorzell
Copy link
Contributor Author

gorzell commented Sep 23, 2016

@elandau can I get a review on this?

@elandau
Copy link
Contributor

elandau commented Nov 11, 2017

@gorzell Sorry for taking so long to look at this. Can you please fix the conflict and I'll go ahead and merge.

@gorzell gorzell requested a review from elandau December 12, 2017 10:52
…feLoaderHelpers

# Conflicts:
#	archaius2-typesafe/build.gradle
@gorzell
Copy link
Contributor Author

gorzell commented Dec 12, 2017

@elandau I fixed the conflict, but something seems to have gone sideways with the build, even the stable/previously successful branches no longer build on my laptop or in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants