Lambdas for proxies take2 #686
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xies This is a re-factor of the code reverted in PR Netflix#685, originally by @kilink
|
I've also realized that, since a ConfigProxyFactory is always initialized after the config object it proxies ... we could have a flag to disable use of lambdas! So anyone hit by the weirdness can just set the flag and keep on leaking proxies to their hearts contents 😁 |
| } else { // Java 17 onwards | ||
| INSTANCE = new LambdasFactory(); | ||
| } | ||
| LOG.info("Choosing {} as invoker factory for default methods", INSTANCE.getClass()); |
There was a problem hiding this comment.
is info or debug more sensible for this?
|
|
||
| // The threshold is simply a best guess. Creating 1000 lambdas for the same interface is almost certainly | ||
| // a leak, right? | ||
| private static final int MAX_SEEN_THRESHOLD = 1000; |
There was a problem hiding this comment.
would a JMH bench trigger stuff like this?
| * provides a noticeable performance boost. This implementation is known to fail in java 9 - 11. It *should* work | ||
| * from 12 or 13 onwards, but we have only tested it in 17 and 21. | ||
| */ | ||
| private static class LambdasFactory extends DefaultMethodInvokerFactory { |
There was a problem hiding this comment.
if package-scoped (final, too) you could make a matrix test and benchmarks, or even fuzzing to rely less on seen in usage stuff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-introduces the usage of lambdas for config proxies. I refactored things into a separate class and split the implementations for different JVMs to make things cleaner. I also introduced a "usage counter" circuit breaker to reduce the chance that users could hit OOM errors like they did before. I'll probably end up removing that later, thought.
There's also a bunch of compiler warning cleanups. I tried to keep those on a separate commit so the actual change is easier to review.