Add Micrometer support #226
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Micrometer and the contribution of is threefold.
Limits. These names are included as tags with nameidin meters.MetricRegistryusing Micrometer'sMeterRegistry.kindtags to bothLimits andLimiters. This is useful in observability to distinguish between differentLimits andLimiters. An example of this is shown inREADME.mdunder sectionMicrometer.Note that 1. is a prerequisite for 2.; Micrometer will return existing meters for the same set of "meter name" + tags. Hence we need to distinguish different meters with different names + tags. I am not too familiar with Spectator; I believe there new meters are always created and hence, this may be a breaking change and should be properly evaluated (as each meter will now have an
idtag).Conceptually, a single
Limitcan be shared among severalLimiters, therefore imo, it make sense to give eachLimitits own name anyway.