Skip to content

Conversation

@Meijuh
Copy link

@Meijuh Meijuh commented Dec 17, 2025

This PR adds support for Micrometer and the contribution of is threefold.

  1. Add names to Limits. These names are included as tags with name id in meters.
  2. Implement MetricRegistry using Micrometer's MeterRegistry.
  3. Add kind tags to both Limits and Limiters. This is useful in observability to distinguish between different Limits and Limiters. An example of this is shown in README.md under section Micrometer.

Note that 1. is a prerequisite for 2.; Micrometer will return existing meters for the same set of "meter name" + tags. Hence we need to distinguish different meters with different names + tags. I am not too familiar with Spectator; I believe there new meters are always created and hence, this may be a breaking change and should be properly evaluated (as each meter will now have an id tag).
Conceptually, a single Limit can be shared among several Limiters, therefore imo, it make sense to give each Limit its own name anyway.

@fedorka fedorka requested a review from umairk79 December 17, 2025 17:01
@umairk79
Copy link
Collaborator

Hi @Meijuh, thanks for the contribution! I will take a look at this tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants