Skip to content

Conversation

@MarcAntoine-Arnaud
Copy link
Contributor

update of #234

@codecov
Copy link

codecov bot commented Oct 16, 2019

Codecov Report

❌ Patch coverage is 2.76498% with 211 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.54%. Comparing base (6d646f2) to head (a030997).
⚠️ Report is 141 commits behind head on master.

Files with missing lines Patch % Lines
...ibrary/tsp_2121/ApplicationTsp2121Composition.java 0.00% 154 Missing ⚠️
...CompositionImageEssenceTsp2121DescriptorModel.java 0.00% 54 Missing ⚠️
...2067_2/CompositionImageEssenceDescriptorModel.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #263      +/-   ##
============================================
- Coverage     67.86%   66.54%   -1.32%     
  Complexity     1609     1609              
============================================
  Files           158      160       +2     
  Lines         11226    11457     +231     
  Branches       1701     1742      +41     
============================================
+ Hits           7618     7624       +6     
- Misses         2798     3023     +225     
  Partials        810      810              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MarcAntoine-Arnaud
Copy link
Contributor Author

Hi @cconcolato,
Do you have time to check it soon ?

Best,
Marc-Antoine

@robjay
Copy link

robjay commented Dec 18, 2019

Hi, is there an ETA of this being released? I noticed that photon now supports application 5, but App 2121-1 is still waiting to be merged and released.

@MarcAntoine-Arnaud
Copy link
Contributor Author

@cconcolato do you have a little bit of time ?
Thanks

@robjay
Copy link

robjay commented Dec 19, 2019

@MarcAntoine-Arnaud, will you be extending this to support TSP 2121-4 ?

APPLICATION_2_COMPOSITION_TYPE(Application2Composition.class, namespacesApplication2Composition),
APPLICATION_2E_COMPOSITION_TYPE(Application2ExtendedComposition.class, namespacesApplication2EComposition),
APPLICATION_5_COMPOSITION_TYPE(Application5Composition.class, namespacesApplication5Composition),
APPLICATION_TSP_2121_COMPOSITION_TYPE(ApplicationTsp2121Composition.class, namespacesApplicationTsp2121Composition),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TSP 2121 has many parts. ApplicationTsp2121 could be replaced by ApplicationTsp2121Part1 or ApplicationDPPProRes.

@cconcolato
Copy link
Contributor

Could you add a test file that exercises the code you added? Code coverage is at 0% for ApplicationTsp2121Composition.java.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants