Skip to content

Fixes tests for GitHub actions. #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theengineear merged 1 commit into from
Mar 6, 2025
Merged

Fixes tests for GitHub actions. #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
122 changes: 61 additions & 61 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@
"@netflix/eslint-config": "3.0.0",
"@netflix/x-test": "1.0.2",
"eslint-plugin-jsdoc": "50.6.3",
"eslint": "9.20.1",
"puppeteer": "24.2.1",
"eslint": "9.21.0",
"puppeteer": "24.3.0",
"tap-parser": "18.0.0",
"typescript": "5.7.3"
"typescript": "5.8.2"
},
"engines": {
"node": ">=22.14",
Expand Down
14 changes: 6 additions & 8 deletions test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,9 @@ import puppeteer from 'puppeteer';
// Open our browser.
const browser = await puppeteer.launch({
timeout: 10000,
// opt-in to the new Chrome headless implementation
// ref: https://developer.chrome.com/articles/new-headless/
headless: 'new',
Copy link
Collaborator Author

@theengineear theengineear Mar 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this setting is outdated now?

args: [
// Disables interactive prompt: Do you want to the application Chromium.app to accept incoming network connections?
// ref: https://github.com/puppeteer/puppeteer/issues/4752#issuecomment-586599843
'--disable-features=DialMediaRouteProvider',
Copy link
Collaborator Author

@theengineear theengineear Mar 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the linked issue and it seemed like it was closed.

],
// These args fix “Error: Failed to launch the browser process!” when
// run in GitHub. We are only running our own code here, so this is ok.
args: ['--no-sandbox', '--disable-setuid-sandbox'],
Copy link
Collaborator Author

@theengineear theengineear Mar 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love a cross-check on this one. I think this is what we need to do now in GitHub based on our settings?

});
const page = await browser.newPage();

Expand Down Expand Up @@ -66,6 +61,9 @@ import puppeteer from 'puppeteer';
// Close our browser.
await browser.close();
} catch (err) {
// Ensure that we “Bail out!” (see TAP specification) if script fails. Note
// that the tap stream is being read on stdout.
console.log('Bail out!'); // eslint-disable-line no-console
Copy link
Collaborator Author

@theengineear theengineear Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @klebba — we should bake this sort of thing into all our test.js files across projects.

// Ensure we exit with a non-zero code if anything fails (e.g., timeout).
console.error(err); // eslint-disable-line no-console
process.exit(1);
Expand Down