dynamically finding crs nodes from xml if matching with preferred crs. if not but has nodes then take first available node from xml. if none apply take our first preferred crs #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. if not but has nodes then take first available node from xml. if none apply take our first preferred crs
mvriel
reviewed
Feb 17, 2025
| @@ -105,6 +105,18 @@ protected string GetInnerTextForNode(XmlNode layerNode, string nodeName, bool se | |||
| } | |||
| } | |||
|
|
|||
| //protected XmlNodeList GetNodesByName(XmlNode layerNode, string nodeName) | |||
mvriel
reviewed
Feb 17, 2025
| } | ||
| if (string.IsNullOrEmpty(spatialReference)) | ||
| { | ||
| spatialReference = crsNodes[0].InnerText; |
There was a problem hiding this comment.
Dit geeft niet de eerste ondersteunde CRS terug maar de eerste in de set crsNodes, zie AC 3. Dit kan een ongeldige situatie opleveren
mvriel
reviewed
Feb 17, 2025
| string spatialReference = null; | ||
| var spatialReferenceType = MapFilters.SpatialReferenceTypeFromVersion(new Version(mapTemplate.version)); | ||
| XmlNodeList crsNodes = GetNodesByName(mapNode, spatialReferenceType); | ||
| if (crsNodes.Count > 0) |
There was a problem hiding this comment.
Als je dit in een methode plaatst dan kan dat leesbaarder en kan je het gebruik van GOTO vermijden omdat je op die plek een return kan doen. Tevens kan het nesting niveau omlaag door het gebruik van early return
mvriel
reviewed
Feb 17, 2025
mvriel
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.