Add linters

[AnkushinDaniil]

This pull request includes multiple changes aimed at improving the codebase by optimizing loops and adding new linters. The most significant changes include replacing traditional for loops with range loops, adding new linters to the configuration, and optimizing array initialization.

Loop Optimization:

• blockchain/blockchain.go: Modified removeTxsAndReceipts function to use range in the loop.
• blockchain/blockchain_test.go: Updated multiple test functions to use range loops instead of traditional loops. [1] [2] [3] [4] [5] [6] [7]
• clients/feeder/feeder.go: Changed the retry loop in get function to use range for better readability.
• cmd/juno/juno_test.go: Updated environment variable handling loops to use range. [1] [2]
• core/crypto/ecdsa_test.go, core/crypto/pedersen_hash_test.go, core/crypto/poseidon_hash_test.go: Replaced loops in benchmark functions with range. [1] [2] [3] [4] [5] [6] [7] [8] [9]

Linter Configuration:

• .golangci.yaml: Added new linters prealloc, makezero, and intrange to the configuration.

Array Initialization:

• cmd/juno/dbcmd.go: Optimized array initialization in dbSize function.
• core/trie/proof_test.go: Updated array initialization in multiple test functions for better performance. [1] [2] [3] [4] [5]
• core/trie/trie_test.go: Improved array initialization in benchmark functions. [1] [2]

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.56%. Comparing base (daeb674) to head (0537486).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2403      +/-   ##
==========================================
- Coverage   74.60%   74.56%   -0.05%     
==========================================
  Files         113      113              
  Lines       13052    13051       -1     
==========================================
- Hits         9738     9732       -6     
- Misses       2583     2586       +3     
- Partials      731      733       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[weiihann]

makezero and prealloc seems good to me.

For intrange, I'm not sure if it actually helps. Personally, it does not help with improving code readability. For example, I'd prefer to see for i := 0; i < len(something); i++ since it's clear to me that it starts at 0 and ends at len(something) - 1. For for i := range len(something), I still have to think about what it actually starts from. Performance wise, I think both are the same? Not super against adding it, but I don't see the benefit of it for now.

[AnkushinDaniil]

Performance wise, I think both are the same?

I've just done some simple benchmarks and range version is about 17% more efficient.

[rodrigo-pino]

I agree with these changes.

In case of int range, I prefer the new way as well. It is syntactic sugar for the same thing, and avoids the need to write the same old for i =0; etc ... .