Chore/blockifier/version update #2848

EgeCaner · 2025-05-20T12:05:22Z

Blockifier version updated to latest commit (not tagged release yet).
Depencies are updated accordingly.
New Blockifier::VersionedConstants were breaking the related tests under vm_test.go due to change in the schema of those constant, related data is updated using this as source.
'Tip' field is utilizd in fee calculation.
Linter suggestions addressed.
AccountExecutionFlags do expect strict_nonce_check field

! Requires rust version >=1.86.0

…onstants from file and update files 'versioned_constants/' to be compatible with new version

…k_context' field from 'BlockContext' to 'Arc<BlockContext>'

codecov · 2025-05-20T12:11:44Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (0.14.0-beta@97e6904). Learn more about missing BASE report.

Additional details and impacted files

@@              Coverage Diff               @@
##             0.14.0-beta    #2848   +/-   ##
==============================================
  Coverage               ?   75.82%           
==============================================
  Files                  ?      186           
  Lines                  ?    20464           
  Branches               ?        0           
==============================================
  Hits                   ?    15516           
  Misses                 ?     3973           
  Partials               ?      975

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions · 2025-05-20T12:15:14Z

Minimum supported Rust version is 1.86.0, previous 1.85.1. Please update the README file, the Makefile, and this workflow.

github-actions · 2025-05-20T15:47:04Z

Minimum supported Rust version is 1.86.0, previous 1.85.1. Please update the README file, the Makefile, and this workflow.

rodrigo-pino

LGTM

rodrigo-pino · 2025-05-22T10:21:08Z

vm/rust/src/lib.rs

@@ -458,6 +459,10 @@ pub extern "C" fn cairoVMExecute(
                            l2_gas: l2_gas_consumed,
                        },
                        &fee_type,
+                        match txn {
+                            Transaction::Account(txn) => txn.tip(),
+                            Transaction::L1Handler(_) => starknet_api::transaction::fields::Tip(0),


Short name here (just Tip(0)). No need for the long name I believe

rodrigo-pino · 2025-05-22T10:21:30Z

vm/rust/src/lib.rs

-            let mut file = File::open(Path::new(&path))
-                .with_context(|| format!("Failed to open file: {}", path))?;
-
-            let mut contents = String::new();
-            file.read_to_string(&mut contents)
-                .with_context(|| format!("Failed to read contents of file: {}", path))?;
-
-            let constants: VersionedConstants = serde_json::from_str(&contents)
+            let constants = VersionedConstants::from_path(Path::new(&path))


* bump blockifier version * Blockifier VersionedConstants: use function from blockifier to read constants from file and update files 'versioned_constants/' to be compatible with new version * Use Tip field * Set 'strict_nonce_check' field to 'true' and 'TransactionContext.block_context' field from 'BlockContext' to 'Arc<BlockContext>' * Address linter suggestion * Updated minimum requried rust version in README and MAKEFILE * use short name for 'Tip' --------- Co-authored-by: Rodrigo <rodrodpino@gmail.com>

* Chore/blockifier/version update (#2848) * bump blockifier version * Blockifier VersionedConstants: use function from blockifier to read constants from file and update files 'versioned_constants/' to be compatible with new version * Use Tip field * Set 'strict_nonce_check' field to 'true' and 'TransactionContext.block_context' field from 'BlockContext' to 'Arc<BlockContext>' * Address linter suggestion * Updated minimum requried rust version in README and MAKEFILE * use short name for 'Tip' --------- Co-authored-by: Rodrigo <rodrodpino@gmail.com> * blockifier version update to new release candidate (#2869) * blockifier version bumped to release candidate * blockifier versioned constants updated * fix proposer test * feat:(Blockifier): convert l2 gas to l1 gas when NoL2Gas (#2942) Blockifier, convert l2 gas to l1 gas when NoL2Gas GasVectorComputationMode and use overidden values in response * Fix/trace result inner execution resources (#2964) * blockifier feature node_api * trace return inner execution resources l1_gas and l2_gas * feat: rpcv9 l1 handler traces return revert reason (#2941) * L1Handler Tx Trace is not REVERTIBLE_FUNCTION_INVOCATION * L1Handler traces return revert reason * RPC version < 9 returns dummy L1_Handler trace for reverted trace * update comments * fix test * use ExecuteInvocation.FunctionInvocation == nil as reverted flag * Add test for reverted L1Handler trace * add AdaptVMTransaction L1Handler reverted for rpc < 9 * update Proposal test for 0.14.0 * update rust version workflow --------- Co-authored-by: Rodrigo <rodrodpino@gmail.com>

EgeCaner added 5 commits May 20, 2025 14:30

bump blockifier version

d1e0282

Blockifier VersionedConstants: use function from blockifier to read c…

48af932

…onstants from file and update files 'versioned_constants/' to be compatible with new version

Use Tip field

c9b032d

Set 'strict_nonce_check' field to 'true' and 'TransactionContext.bloc…

b44fae6

…k_context' field from 'BlockContext' to 'Arc<BlockContext>'

Address linter suggestion

f1b622d

EgeCaner temporarily deployed to Development May 20, 2025 12:20 — with GitHub Actions Inactive

Updated minimum requried rust version in README and MAKEFILE

3f6bb27

EgeCaner changed the base branch from main to 0.14.0-beta May 20, 2025 15:43

EgeCaner temporarily deployed to Development May 20, 2025 15:54 — with GitHub Actions Inactive

EgeCaner marked this pull request as ready for review May 22, 2025 09:10

EgeCaner requested review from rodrigo-pino and rianhughes May 22, 2025 09:39

rodrigo-pino approved these changes May 22, 2025

View reviewed changes

use short name for 'Tip'

0de029f

EgeCaner requested a review from infrmtcs May 22, 2025 11:52

Merge branch '0.14.0-beta' into chore/blockifier/version-update

be20eee

rodrigo-pino merged commit bb5c734 into 0.14.0-beta May 26, 2025
5 checks passed

rodrigo-pino deleted the chore/blockifier/version-update branch May 26, 2025 20:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Chore/blockifier/version update #2848

Chore/blockifier/version update #2848

Uh oh!

EgeCaner commented May 20, 2025 •

edited

Loading

Uh oh!

codecov bot commented May 20, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 20, 2025

Uh oh!

github-actions bot commented May 20, 2025

Uh oh!

rodrigo-pino left a comment

Uh oh!

rodrigo-pino May 22, 2025

Uh oh!

rodrigo-pino May 22, 2025

Uh oh!

Uh oh!

Uh oh!

Chore/blockifier/version update #2848

Chore/blockifier/version update #2848

Uh oh!

Conversation

EgeCaner commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented May 20, 2025

Uh oh!

github-actions bot commented May 20, 2025

Uh oh!

rodrigo-pino left a comment

Choose a reason for hiding this comment

Uh oh!

rodrigo-pino May 22, 2025

Choose a reason for hiding this comment

Uh oh!

rodrigo-pino May 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

EgeCaner commented May 20, 2025 •

edited

Loading

codecov bot commented May 20, 2025 •

edited

Loading